Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete comments in the stream #989

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

digital-dreamer
Copy link

Allows you to delete your comments directly in the stream, just like any other post. A little improvement upon Mathias's idea.

@matzegebbe
Copy link
Contributor

thank you!!! i had problems with shared posts that shows many many extra menus. but this was caused by my own changes i think... you don't get extra-menu on shared posts?

&& activity.get("verb") == "post") in the if clause works for me

@digital-dreamer
Copy link
Author

The cause was a misbehaving jQuery selector. I didn't expect that shared posts have a different CSS structure (2 .muted class elements), so I didn't think of testing them separately. Thank you for pointing it out :-)

@strugee
Copy link
Member

strugee commented Feb 9, 2017

@digital-dreamer can you rebase this on top of current master? I'd be interested in merging this patch :)

@strugee strugee reopened this Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants