Skip to content

Conversation

@kimberleyamackenzie
Copy link
Contributor

@claude
Copy link
Contributor

claude bot commented Nov 26, 2025

Review Summary

This PR updates the re:Invent landing page to focus on post-event engagement and AWS credits promotion. The changes simplify the hero section and replace event-specific cards with evergreen content. I found several issues that need attention:


Issues Found

1. Trailing Spaces in HTML (layouts/page/reinvent.html:10, 31)

Lines 10 and 31 have trailing spaces that should be removed per AGENTS.md.

Line 10: Remove trailing space after </div>

Line 31: Remove multiple trailing spaces after the closing </div>

2. Long URL Breaking Code Readability (layouts/page/reinvent.html:26-28)

The Neo demo URLs are extremely long (over 150 characters) and make the code hard to read and maintain. The URL parameters include a long encoded prompt. Consider:

  • Storing the base URL and parameters in Hugo config
  • Creating a shortcode for Neo links
  • Using a URL shortener for marketing campaigns

3. Inconsistent Border Styling (layouts/page/reinvent.html:22, 40, 54, 68)

The card icon circles mix Tailwind utility classes with inline hex colors inconsistently:

  • Line 22: border-blue-500 class but inline style uses #3545D7
  • Line 40: border-orange-500 class but inline style uses #ee975c
  • Line 54: No Tailwind class, only inline #805ac3
  • Line 68: border-orange-500 class but inline style uses #A25BA8

Choose one approach (Tailwind classes OR inline styles) for consistency and maintainability.

4. Missing Image Files Validation (Required)

The PR references new image files that need verification:

  • /images/reinvent/neo.png (line 23)
  • /images/reinvent/coding.png (line 42)
  • /images/reinvent/interests.png (line 56)

Please confirm these images exist in the repository.

5. Accessibility: Vague Alt Text (layouts/page/reinvent.html:56)

Alt text "Connect" is not descriptive per STYLE-GUIDE.md. Should describe what the image shows or represents. Suggest: "Slack community icon" or "Community connection icon".

6. Time-Sensitive Content Management (layouts/page/reinvent.html:8)

The text "Available to the first 20 new signups from re:Invent" creates potential maintenance issues:

  • No mechanism shown to update when slots fill
  • Will become misleading if left after promotion ends
  • Consider adding a date range or removal plan

7. Button Text Length (layouts/page/reinvent.html:26)

"Build a GPU-powered AI inference API on AWS using Python" is 9 words / 56 characters. Best practices suggest 2-5 words for buttons. While responsive text helps, consider shorter phrasing like "Build with Neo" or "Try Neo Demo".


Positive Changes

  • Simplified hero removes unnecessary desktop-specific code
  • Clear CTA hierarchy with AWS credits as primary offer
  • Evergreen content replaces dated event details
  • Responsive button text for mobile/desktop

Action Items

Required before merge:

  1. Remove trailing spaces on lines 10 and 31
  2. Verify all three new image files exist

Recommended:
3. Refactor long URLs for maintainability
4. Standardize border styling approach
5. Improve alt text for accessibility
6. Shorten primary button text
7. Plan for time-sensitive promotion content updates


Mention me (@claude) if you need help with fixes or have questions!

@pulumi-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants