-
Notifications
You must be signed in to change notification settings - Fork 245
Add Customer Managed Keys Docs #15284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Your site preview for commit 04f29fc is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-15284-04f29fce.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit 29e6e68 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-15284-29e6e680.s3-website.us-west-2.amazonaws.com. |
content/docs/pulumi-cloud/admin/customer-managed-keys/_index.md
Outdated
Show resolved
Hide resolved
content/docs/pulumi-cloud/admin/customer-managed-keys/_index.md
Outdated
Show resolved
Hide resolved
content/docs/pulumi-cloud/admin/customer-managed-keys/aws-kms.md
Outdated
Show resolved
Hide resolved
Your site preview for commit efc7974 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-15284-efc79746.s3-website.us-west-2.amazonaws.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
content/docs/pulumi-cloud/admin/customer-managed-keys/_index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some nits and questions, but no blockers
content/docs/pulumi-cloud/admin/customer-managed-keys/_index.md
Outdated
Show resolved
Hide resolved
content/docs/pulumi-cloud/admin/customer-managed-keys/_index.md
Outdated
Show resolved
Hide resolved
content/docs/pulumi-cloud/admin/customer-managed-keys/_index.md
Outdated
Show resolved
Hide resolved
content/docs/pulumi-cloud/admin/customer-managed-keys/_index.md
Outdated
Show resolved
Hide resolved
Your site preview for commit 2435ff5 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-15284-2435ff53.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit 42dbf36 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-15284-42dbf366.s3-website.us-west-2.amazonaws.com. |
Proposed changes
Added docs for the upcoming customer managed keys feature