Skip to content

Add property search and adjusting resource query limit for team sku #14907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 5, 2025

Conversation

DukeBWard
Copy link
Contributor

@DukeBWard DukeBWard commented May 1, 2025

Proposed changes

  • content/pricing/_index.md : add check for property search for team and adjusting resource query limit from 2k -> 10k
  • content/docs/insights/search.md : adjusted property search tool tip from only enterprise and biz crit to team, enterprise and biz crit

Unreleased product version (optional)

N/A

Related issues (optional)

Reference https://github.com/pulumi/pulumi-service/issues/27667
image
image

@DukeBWard DukeBWard self-assigned this May 1, 2025
@DukeBWard DukeBWard requested a review from Copilot May 1, 2025 14:28
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the documentation for property search and adjusts the resource query limit for the team SKU.

  • Updated the resource query limit from 2K to 10K results in the pricing documentation.
  • Changed the property search eligibility and icon display in both the pricing and insights documentation files.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
content/pricing/_index.md Updated resource query limit and icon to reflect team SKU eligibility
content/docs/insights/search.md Revised eligibility text for property search to include the Team edition
Comments suppressed due to low confidence (3)

content/pricing/_index.md:332

  • [nitpick] Verify that updating the resource query limit to 10K results aligns with the backend configuration and overall product specifications.
                    - content: 10K results

content/pricing/_index.md:346

  • [nitpick] Ensure that the replacement of '_blank' with '_check' accurately represents property search availability for the team SKU as intended.
                    - content: _check

content/docs/insights/search.md:274

  • [nitpick] Confirm that the updated eligibility criteria in the property search text consistently aligns with service specifications and any related documentation.
Property search is only available to organizations using Team, Enterprise and Business Critical editions.

@pulumi-bot
Copy link
Collaborator

@DukeBWard DukeBWard requested a review from shughes26 May 1, 2025 14:35
@AnuiDolphin
Copy link
Contributor

We should remove the 'Per query limits' row completely. While 'per query limits' is technically true, you can work around this by grouping your results, so from a user perspective, it is 10k per group. This is too much to describe in a pricing page now that the limits are the same across all SKUs.

@pulumi-bot
Copy link
Collaborator

@DukeBWard DukeBWard merged commit 151a834 into master May 5, 2025
8 checks passed
@DukeBWard DukeBWard deleted the lward/team-sku-property-search branch May 5, 2025 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants