-
Notifications
You must be signed in to change notification settings - Fork 240
Add property search and adjusting resource query limit for team sku #14907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the documentation for property search and adjusts the resource query limit for the team SKU.
- Updated the resource query limit from 2K to 10K results in the pricing documentation.
- Changed the property search eligibility and icon display in both the pricing and insights documentation files.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
content/pricing/_index.md | Updated resource query limit and icon to reflect team SKU eligibility |
content/docs/insights/search.md | Revised eligibility text for property search to include the Team edition |
Comments suppressed due to low confidence (3)
content/pricing/_index.md:332
- [nitpick] Verify that updating the resource query limit to 10K results aligns with the backend configuration and overall product specifications.
- content: 10K results
content/pricing/_index.md:346
- [nitpick] Ensure that the replacement of '_blank' with '_check' accurately represents property search availability for the team SKU as intended.
- content: _check
content/docs/insights/search.md:274
- [nitpick] Confirm that the updated eligibility criteria in the property search text consistently aligns with service specifications and any related documentation.
Property search is only available to organizations using Team, Enterprise and Business Critical editions.
Your site preview for commit ba9f31f is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-14907-ba9f31f5.s3-website.us-west-2.amazonaws.com. |
We should remove the 'Per query limits' row completely. While 'per query limits' is technically true, you can work around this by grouping your results, so from a user perspective, it is 10k per group. This is too much to describe in a pricing page now that the limits are the same across all SKUs. |
Your site preview for commit 0e9f032 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-14907-0e9f032a.s3-website.us-west-2.amazonaws.com. |
Proposed changes
content/pricing/_index.md
: add check for property search for team and adjusting resource query limit from 2k -> 10kcontent/docs/insights/search.md
: adjusted property search tool tip from only enterprise and biz crit to team, enterprise and biz critUnreleased product version (optional)
N/A
Related issues (optional)
Reference https://github.com/pulumi/pulumi-service/issues/27667

