Optimize ACS pipeline for runtime and memory #5832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution! |
|
This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details. |
Lift some queries that were performed per-batch outside of the loop, resolving an N+1 where N=number of batches. Also use .iterator()
Instead of performing a gigantic AND-ed OR clause query, break up the list of remote artifacts by checksum type and perform one IN query per type of checksum, which ought to be easily indexable.
ggainey
requested changes
Feb 24, 2025
Lift the ACS domain check out of the stage entirely.
dralley
force-pushed
the
acs-optimize
branch
from
372ebfa to
3b71be5
Compare
ggainey
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, I can tell that it at least reduced runtimes by about 75%, but the memory use improvement is minimal.