Issue 474 fallback to encryption for React Native when CipherKey is present #476
+161
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
nholik
force-pushed
the
issue-474-rn-fallback-encryption
branch
from
b9d405e to
1ba888e
Compare
nholik
force-pushed
the
issue-474-rn-fallback-encryption
branch
from
1ba888e to
a508cc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in Issue 474, when a cipherKey value is passed in the configuration arguments, instead of using the legacy crypto functionality like in other areas, there is a silent fallback to plaintext as the new design relies on the presence of a defined ICryptoModule. This PR gives a fallback to the legacy encryption methods when a cipherkey is passed in, as this is likely the expectation of users, particularly coming from earlier versions of the library, then passing in this value.
To accomplish this, there are two small changes: