Fix issue with presence events

.pubnub.yml

@@ -1,5 +1,10 @@
 ---
 changelog:
+  - date: 2025-03-31
+    version: v9.3.2
+    changes:
+      - type: bug
+        text: "Fix missing `heartbeat` and `leave` REST API calls when the event engine is enabled and `presenceTimeout` or `heartbeatInterval` not set."
   - date: 2025-03-25
     version: v9.3.1
     changes:
@@ -1197,7 +1202,7 @@ supported-platforms:
       - 'Ubuntu 14.04 and up'
       - 'Windows 7 and up'
     version: 'Pubnub Javascript for Node'
-version: '9.3.1'
+version: '9.3.2'
 sdks:
   - full-name: PubNub Javascript SDK
     short-name: Javascript
@@ -1213,7 +1218,7 @@ sdks:
           - distribution-type: source
             distribution-repository: GitHub release
             package-name: pubnub.js
-            location: https://github.com/pubnub/javascript/archive/refs/tags/v9.3.1.zip
+            location: https://github.com/pubnub/javascript/archive/refs/tags/v9.3.2.zip
             requires:
               - name: 'agentkeepalive'
                 min-version: '3.5.2'
@@ -1884,7 +1889,7 @@ sdks:
           - distribution-type: library
             distribution-repository: GitHub release
             package-name: pubnub.js
-            location: https://github.com/pubnub/javascript/releases/download/v9.3.1/pubnub.9.3.1.js
+            location: https://github.com/pubnub/javascript/releases/download/v9.3.2/pubnub.9.3.2.js
             requires:
               - name: 'agentkeepalive'
                 min-version: '3.5.2'

CHANGELOG.md

@@ -1,3 +1,9 @@
+## v9.3.2
+March 31 2025
+
+#### Fixed
+- Fix missing `heartbeat` and `leave` REST API calls when the event engine is enabled and `presenceTimeout` or `heartbeatInterval` not set.
+
 ## v9.3.1
 March 25 2025
 

README.md

@@ -27,8 +27,8 @@ Watch [Getting Started with PubNub JS SDK](https://app.dashcam.io/replay/64ee0d2
      npm install pubnub
      ```
    * or download one of our builds from our CDN: 
-     * https://cdn.pubnub.com/sdk/javascript/pubnub.9.3.1.js
-     * https://cdn.pubnub.com/sdk/javascript/pubnub.9.3.1.min.js
+     * https://cdn.pubnub.com/sdk/javascript/pubnub.9.3.2.js
+     * https://cdn.pubnub.com/sdk/javascript/pubnub.9.3.2.min.js
 
 2. Configure your keys:
 

dist/web/pubnub.js

@@ -3939,7 +3939,7 @@
 	            return base.PubNubFile;
 	        },
 	        get version() {
-	            return '9.3.1';
+	            return '9.3.2';
 	        },
 	        getVersion() {
 	            return this.version;
@@ -8641,6 +8641,8 @@
 	        }
 	    }
 	    unsubscribeAll() {
+	        const channelGroups = this.getSubscribedChannels();
+	        const channels = this.getSubscribedChannels();
 	        this.channels = [];
 	        this.groups = [];
 	        if (this.dependencies.presenceState) {
@@ -8649,18 +8651,18 @@
 	            });
 	        }
 	        this.engine.transition(subscriptionChange(this.channels.slice(0), this.groups.slice(0)));
-	        if (this.dependencies.leaveAll) {
-	            this.dependencies.leaveAll();
-	        }
+	        if (this.dependencies.leaveAll)
+	            this.dependencies.leaveAll({ channels, groups: channelGroups });
 	    }
 	    reconnect({ timetoken, region }) {
 	        this.engine.transition(reconnect(timetoken, region));
 	    }
 	    disconnect() {
+	        const channelGroups = this.getSubscribedChannels();
+	        const channels = this.getSubscribedChannels();
 	        this.engine.transition(disconnect());
-	        if (this.dependencies.leaveAll) {
-	            this.dependencies.leaveAll();
-	        }
+	        if (this.dependencies.leaveAll)
+	            this.dependencies.leaveAll({ channels, groups: channelGroups });
 	    }
 	    getSubscribedChannels() {
 	        return Array.from(new Set(this.channels.slice(0)));
@@ -14024,8 +14026,13 @@
 	     * @param parameters - List of channels and groups where `join` event should be sent.
 	     */
 	    join(parameters) {
-	        var _a;
-	        (_a = this.presenceEventEngine) === null || _a === void 0 ? void 0 : _a.join(parameters);
+	        {
+	            if (this.presenceEventEngine)
+	                this.presenceEventEngine.join(parameters);
+	            else {
+	                this.heartbeat(Object.assign(Object.assign({ channels: parameters.channels, channelGroups: parameters.groups }, (this._configuration.maintainPresenceState && { state: this.presenceState })), { heartbeat: this._configuration.getPresenceTimeout() }), () => { });
+	            }
+	        }
 	    }
 	    // endregion
 	    // region Leave
@@ -14038,16 +14045,27 @@
 	     */
 	    leave(parameters) {
 	        var _a;
-	        (_a = this.presenceEventEngine) === null || _a === void 0 ? void 0 : _a.leave(parameters);
+	        {
+	            if (this.presenceEventEngine)
+	                (_a = this.presenceEventEngine) === null || _a === void 0 ? void 0 : _a.leave(parameters);
+	            else
+	                this.makeUnsubscribe({ channels: parameters.channels, channelGroups: parameters.groups }, () => { });
+	        }
 	    }
 	    /**
 	     * Announce user `leave` on all subscribed channels.
 	     *
 	     * @internal
+	     *
+	     * @param parameters - List of channels and groups where `leave` event should be sent.
 	     */
-	    leaveAll() {
-	        var _a;
-	        (_a = this.presenceEventEngine) === null || _a === void 0 ? void 0 : _a.leaveAll();
+	    leaveAll(parameters) {
+	        {
+	            if (this.presenceEventEngine)
+	                this.presenceEventEngine.leaveAll();
+	            else
+	                this.makeUnsubscribe({ channels: parameters.channels, channelGroups: parameters.groups }, () => { });
+	        }
 	    }
 	    /**
 	     * Grant token permission.

lib/core/components/configuration.js

@@ -124,7 +124,7 @@ const makeConfiguration = (base, setupCryptoModule) => {
             return base.PubNubFile;
         },
         get version() {
-            return '9.3.1';
+            return '9.3.2';
         },
         getVersion() {
             return this.version;

lib/core/endpoints/fetch_messages.js

@@ -20,13 +20,23 @@ var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (
 }) : function(o, v) {
     o["default"] = v;
 });
-var __importStar = (this && this.__importStar) || function (mod) {
-    if (mod && mod.__esModule) return mod;
-    var result = {};
-    if (mod != null) for (var k in mod) if (k !== "default" && Object.prototype.hasOwnProperty.call(mod, k)) __createBinding(result, mod, k);
-    __setModuleDefault(result, mod);
-    return result;
-};
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
 var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
     function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
     return new (P || (P = Promise))(function (resolve, reject) {

lib/core/pubnub-common.js

@@ -18,13 +18,23 @@ var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (
 }) : function(o, v) {
     o["default"] = v;
 });
-var __importStar = (this && this.__importStar) || function (mod) {
-    if (mod && mod.__esModule) return mod;
-    var result = {};
-    if (mod != null) for (var k in mod) if (k !== "default" && Object.prototype.hasOwnProperty.call(mod, k)) __createBinding(result, mod, k);
-    __setModuleDefault(result, mod);
-    return result;
-};
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
 var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
     function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
     return new (P || (P = Promise))(function (resolve, reject) {
@@ -1343,9 +1353,13 @@ class PubNubCore {
      * @param parameters - List of channels and groups where `join` event should be sent.
      */
     join(parameters) {
-        var _a;
-        if (process.env.PRESENCE_MODULE !== 'disabled')
-            (_a = this.presenceEventEngine) === null || _a === void 0 ? void 0 : _a.join(parameters);
+        if (process.env.PRESENCE_MODULE !== 'disabled') {
+            if (this.presenceEventEngine)
+                this.presenceEventEngine.join(parameters);
+            else {
+                this.heartbeat(Object.assign(Object.assign({ channels: parameters.channels, channelGroups: parameters.groups }, (this._configuration.maintainPresenceState && { state: this.presenceState })), { heartbeat: this._configuration.getPresenceTimeout() }), () => { });
+            }
+        }
         else
             throw new Error('Announce UUID Presence error: presence module disabled');
     }
@@ -1360,20 +1374,29 @@ class PubNubCore {
      */
     leave(parameters) {
         var _a;
-        if (process.env.PRESENCE_MODULE !== 'disabled')
-            (_a = this.presenceEventEngine) === null || _a === void 0 ? void 0 : _a.leave(parameters);
+        if (process.env.PRESENCE_MODULE !== 'disabled') {
+            if (this.presenceEventEngine)
+                (_a = this.presenceEventEngine) === null || _a === void 0 ? void 0 : _a.leave(parameters);
+            else
+                this.makeUnsubscribe({ channels: parameters.channels, channelGroups: parameters.groups }, () => { });
+        }
         else
             throw new Error('Announce UUID Leave error: presence module disabled');
     }
     /**
      * Announce user `leave` on all subscribed channels.
      *
      * @internal
+     *
+     * @param parameters - List of channels and groups where `leave` event should be sent.
      */
-    leaveAll() {
-        var _a;
-        if (process.env.PRESENCE_MODULE !== 'disabled')
-            (_a = this.presenceEventEngine) === null || _a === void 0 ? void 0 : _a.leaveAll();
+    leaveAll(parameters) {
+        if (process.env.PRESENCE_MODULE !== 'disabled') {
+            if (this.presenceEventEngine)
+                this.presenceEventEngine.leaveAll();
+            else
+                this.makeUnsubscribe({ channels: parameters.channels, channelGroups: parameters.groups }, () => { });
+        }
         else
             throw new Error('Announce UUID Leave error: presence module disabled');
     }

lib/crypto/modules/NodeCryptoModule/aesCbcCryptor.js

@@ -81,7 +81,7 @@ class AesCbcCryptor {
                 let data = stream.stream.read();
                 while (data !== null) {
                     if (data) {
-                        const bChunk = Buffer.from(data);
+                        const bChunk = typeof data === 'string' ? Buffer.from(data) : data;
                         const sliceLen = stream.metadataLength - bIv.byteLength;
                         if (bChunk.byteLength < sliceLen) {
                             bIv = Buffer.concat([bIv, bChunk]);

lib/event-engine/dispatcher.js

@@ -20,13 +20,23 @@ var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (
 }) : function(o, v) {
     o["default"] = v;
 });
-var __importStar = (this && this.__importStar) || function (mod) {
-    if (mod && mod.__esModule) return mod;
-    var result = {};
-    if (mod != null) for (var k in mod) if (k !== "default" && Object.prototype.hasOwnProperty.call(mod, k)) __createBinding(result, mod, k);
-    __setModuleDefault(result, mod);
-    return result;
-};
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
 var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
     function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
     return new (P || (P = Promise))(function (resolve, reject) {

lib/event-engine/index.js

@@ -20,13 +20,23 @@ var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (
 }) : function(o, v) {
     o["default"] = v;
 });
-var __importStar = (this && this.__importStar) || function (mod) {
-    if (mod && mod.__esModule) return mod;
-    var result = {};
-    if (mod != null) for (var k in mod) if (k !== "default" && Object.prototype.hasOwnProperty.call(mod, k)) __createBinding(result, mod, k);
-    __setModuleDefault(result, mod);
-    return result;
-};
+var __importStar = (this && this.__importStar) || (function () {
+    var ownKeys = function(o) {
+        ownKeys = Object.getOwnPropertyNames || function (o) {
+            var ar = [];
+            for (var k in o) if (Object.prototype.hasOwnProperty.call(o, k)) ar[ar.length] = k;
+            return ar;
+        };
+        return ownKeys(o);
+    };
+    return function (mod) {
+        if (mod && mod.__esModule) return mod;
+        var result = {};
+        if (mod != null) for (var k = ownKeys(mod), i = 0; i < k.length; i++) if (k[i] !== "default") __createBinding(result, mod, k[i]);
+        __setModuleDefault(result, mod);
+        return result;
+    };
+})();
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.EventEngine = void 0;
 const core_1 = require("./core");
@@ -105,6 +115,8 @@ class EventEngine {
         }
     }
     unsubscribeAll() {
+        const channelGroups = this.getSubscribedChannels();
+        const channels = this.getSubscribedChannels();
         this.channels = [];
         this.groups = [];
         if (this.dependencies.presenceState) {
@@ -113,18 +125,18 @@ class EventEngine {
             });
         }
         this.engine.transition(events.subscriptionChange(this.channels.slice(0), this.groups.slice(0)));
-        if (this.dependencies.leaveAll) {
-            this.dependencies.leaveAll();
-        }
+        if (this.dependencies.leaveAll)
+            this.dependencies.leaveAll({ channels, groups: channelGroups });
     }
     reconnect({ timetoken, region }) {
         this.engine.transition(events.reconnect(timetoken, region));
     }
     disconnect() {
+        const channelGroups = this.getSubscribedChannels();
+        const channels = this.getSubscribedChannels();
         this.engine.transition(events.disconnect());
-        if (this.dependencies.leaveAll) {
-            this.dependencies.leaveAll();
-        }
+        if (this.dependencies.leaveAll)
+            this.dependencies.leaveAll({ channels, groups: channelGroups });
     }
     getSubscribedChannels() {
         return Array.from(new Set(this.channels.slice(0)));