-
Notifications
You must be signed in to change notification settings - Fork 59
Add ability to configure TCP keepalive #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+402
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide interfaces (`pubnub_use_tcp_keep_alive`, `pubnub_dont_use_tcp_keep_alive`, `use_tcp_keep_alive`, and `dont_use_tcp_keep_alive`) to set up active TCP connection keep-alive packet sending.
Replace the Windows API, which in a multithreaded environment became a reason for crashes during the DNS resolution process. Co-authored-by: Kamil Gronek <[email protected]>
On Windows TCP Keep-Alive settings should be applied after successful socket connection.
KGronek-Pubnub
approved these changes
Oct 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :) tested on Windows
@pubnub-release-bot release |
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
priority: high
This PR should be reviewed ASAP.
status: done
This issue is considered resolved.
type: feature
This PR contains new feature.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(tcp-keepalive): add ability to configure TCP keepalive
Provide interfaces (
pubnub_use_tcp_keep_alive
,pubnub_dont_use_tcp_keep_alive
,use_tcp_keep_alive
, anddont_use_tcp_keep_alive
) to set up active TCP connection keep-alive packet sending.fix(dns): fix crash on Windows system DNS
Replace the Windows API, which in a multithreaded environment became a reason for crashes during the DNS resolution process.
fix(sockets): address issue with additional socket
Fix the issue because of which client created a secondary connection when built with
PUBNUB_USE_IPV6
support.