Update Node version to 8 and 10

[keshav234156]

Fixes #439 #205

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt jasmine
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• PR body includes fixes #0000-style reference to original issue #
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

[keshav234156]

@cesswairimu

[cesswairimu]

@jywarren @emilyashley could you please merge this one...Got no merging rights on this repo

[keshav234156]

@harshkhandeparkar @VladimirMikulic strangely tests are working fine on Node 8 but are failing on Node 10. I think we also have faced a similar issue before #205. Any ideas about this

[harshkhandeparkar]

Can you post what the error is, here?

…

On Mon, 30 Mar, 2020, 9:24 PM keshav234156, ***@***.***> wrote: @harshkhandeparkar <https://github.com/HarshKhandeparkar> @VladimirMikulic <https://github.com/VladimirMikulic> strangely tests are working fine on Node 8 but are failing on Node 10. I think we also have faced a similar issue before #205 <#205>. Any ideas about this — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#441 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIJI5H57USF5BHAPZHD5NQTRKC6CRANCNFSM4LWB2OFQ> .

[VladimirMikulic]

@keshav234156 since Node v10, fs.writeFile requires a callback function to be passed in. One of the dependencies is not passing the callback and it throws an error.

[keshav234156]

Fatal error: Callback must be a function
The command "grunt jasmine" exited with 3.

[VladimirMikulic]

You would need to dig into node_modules in order to fix this. It's a problem with Jasmine.
Read more here.

[harshkhandeparkar]

Is jasmine version up to date?

…

On Mon, 30 Mar, 2020, 9:33 PM Vladimir Mikulic, ***@***.***> wrote: You would need to dig into node_modules in order to fix this. It's a problem with Jasmine. Read more here <gruntjs/grunt-contrib-jasmine#266>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#441 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIJI5H5QNODIURTCS3C2QJTRKC7DRANCNFSM4LWB2OFQ> .

[keshav234156]

Fatal error: Callback must be a function

is also present in Node 8 and error was also thrown in earlier versions of Node but it didn't failed the travis.

In Node 10 the extra error is

The command "grunt jasmine" exited with 3.

[VladimirMikulic]

I guess our setup is outdated.

[harshkhandeparkar]

`grunt jasmine` exited with 3 is not an extra error. It just tells you that nodejs v10 handles the errors in a different way. When the same error occurred in v8, nodejs caught the error but didn't stop the script or return a non-zero exit code. In v10, it caught the error, stopped the execution and reported to travis that the script had failed.

…

On Mon, 30 Mar, 2020, 10:07 PM keshav234156, ***@***.***> wrote: Fatal error: Callback must be a function is also present in Node 8 and error was also thrown in earlier versions of Node but it didn't failed the travis. In Node 10 the extra error is The command "grunt jasmine" exited with 3. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#441 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIJI5H7UOI2KNK4AROGEWXTRKDDFTANCNFSM4LWB2OFQ> .

[keshav234156]

@VladimirMikulic @harshkhandeparkar Fixed by updataing grunt-jasmine-contrib

[harshkhandeparkar]

Great! Always update dependencies!

…

On Mon, 30 Mar, 2020, 11:07 PM keshav234156, ***@***.***> wrote: @VladimirMikulic <https://github.com/VladimirMikulic> @harshkhandeparkar <https://github.com/HarshKhandeparkar> Fixed by updataing grunt-jasmine-contrib — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#441 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIJI5H3EZPUSG4ZUYD5KBDLRKDKEXANCNFSM4LWB2OFQ> .

[VladimirMikulic]

We are ready 👍

[jywarren]

Looks great folks, thanks a ton!