-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify linked document and fix pdf link #884
Conversation
Here's the logic for linking to the page, rather than the PDF: #867 (review) |
But this entry has two links to the same page, one to the page, and one that claims to be a direct link to the PDF (but isn't, that's my fix). If we don't want the link to the PDF, the |
This is the redundancy I want to fix. Two links, labelled differently, but that goes to the same place. In my opinion, if the second one (labelled PDF) should still be there, it should link somewhere else. And why not to the PDF directly when the first one links to the page hosting it? |
@Ainali, I agree with your proposal, but don't think the way we currently present PDFs is distinct enough for someone to notice that the very long hyperlink for the report name is a different from the link to [PDF]. I had a quick look yesterday for conventions for presenting PDFs vs holding pages for PDFs when there isn't an HTML version of the PDF, but haven't found one yet that looks like a nice one for us to borrow. |
That's a good point. I think my suggestion in publiccodenet/projects#27 might be useful, that is putting the link inside the brackets to show it's not one long continouos link. In this case, I could change it to:
|
@Ainali I like it! It's subtle, but let's try it. |
@Ainali What do you think of my most recent changes? |
I like it, very clear! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There are many PDF documents on the page, so it might be helpful to specify which one to look for. Also, the direct link to the PDF was going to the same webpage.
View rendered activities/value-and-impact/policy-documents.md