Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify linked document and fix pdf link #884

Merged
merged 17 commits into from
Jul 22, 2021
Merged

Clarify linked document and fix pdf link #884

merged 17 commits into from
Jul 22, 2021

Conversation

Ainali
Copy link
Member

@Ainali Ainali commented Mar 15, 2021

There are many PDF documents on the page, so it might be helpful to specify which one to look for. Also, the direct link to the PDF was going to the same webpage.


View rendered activities/value-and-impact/policy-documents.md

@Ainali Ainali requested a review from lscheske March 15, 2021 11:03
@Ainali Ainali requested a review from a team as a code owner March 15, 2021 11:03
@ElenaFdR
Copy link
Member

Here's the logic for linking to the page, rather than the PDF: #867 (review)

@Ainali
Copy link
Member Author

Ainali commented Mar 15, 2021

Here's the logic for linking to the page, rather than the PDF: #867 (review)

But this entry has two links to the same page, one to the page, and one that claims to be a direct link to the PDF (but isn't, that's my fix). If we don't want the link to the PDF, the [PDF] should be removed completely.

@Ainali
Copy link
Member Author

Ainali commented Mar 23, 2021

Here's the logic for linking to the page, rather than the PDF: #867 (review)

But this entry has two links to the same page, one to the page, and one that claims to be a direct link to the PDF (but isn't, that's my fix). If we don't want the link to the PDF, the [PDF] should be removed completely.

to achieve the goals set out in the [A Digital City Agenda (Agenda Digitale Stad)](https://www.amsterdam.nl/wonen-leefomgeving/innovatie/de-digitale-stad/) [[PDF]](https://www.amsterdam.nl/wonen-leefomgeving/innovatie/de-digitale-stad/)

This is the redundancy I want to fix. Two links, labelled differently, but that goes to the same place. In my opinion, if the second one (labelled PDF) should still be there, it should link somewhere else. And why not to the PDF directly when the first one links to the page hosting it?

@ElenaFdR
Copy link
Member

@Ainali, I agree with your proposal, but don't think the way we currently present PDFs is distinct enough for someone to notice that the very long hyperlink for the report name is a different from the link to [PDF]. I had a quick look yesterday for conventions for presenting PDFs vs holding pages for PDFs when there isn't an HTML version of the PDF, but haven't found one yet that looks like a nice one for us to borrow.

@Ainali
Copy link
Member Author

Ainali commented Mar 23, 2021

That's a good point. I think my suggestion in publiccodenet/projects#27 might be useful, that is putting the link inside the brackets to show it's not one long continouos link. In this case, I could change it to:

of the municipal strategies to achieve the goals set out in the A Digital City Agenda (Agenda Digitale Stad Tussenrapportage 2019 - 2020) [PDF] (in Dutch)

@ElenaFdR
Copy link
Member

@Ainali I like it! It's subtle, but let's try it.

@ElenaFdR
Copy link
Member

@Ainali What do you think of my most recent changes?

@Ainali
Copy link
Member Author

Ainali commented Apr 8, 2021

@Ainali What do you think of my most recent changes?

I like it, very clear!

ericherman
ericherman previously approved these changes Jul 22, 2021
Copy link
Member

@bvhme bvhme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Ainali Ainali merged commit 078c59c into develop Jul 22, 2021
@Ainali Ainali deleted the ja-fix-pdf-link branch July 22, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants