Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update maxDiffPixelRatio for visual tests to improve screenshot accuracy #7384

Merged

Conversation

deleonio
Copy link
Contributor

@deleonio deleonio commented Feb 15, 2025

Refs: #7383
This pull request includes a small change to the packages/tools/visual-tests/tests/theme-snapshots.spec.js file. The change adjusts the maxDiffPixelRatio value in the visual test configuration.

The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer:

  • Meaningful pull request title for the release notes
  • Pull request is linked to an issue and all changes relate to the issue
  • Tests to protect this code implemented (if applicable)
  • Manual test performed successfully (if applicable)
  • Documentation or migration has been updated (if applicable)

@deleonio deleonio changed the title fix: correct indentation in publish workflow for environment variables fix: update maxDiffPixelRatio for visual tests to improve screenshot accuracy Feb 15, 2025
Copy link
Contributor

@deleonio deleonio merged commit dbb6303 into release/2 Feb 15, 2025
8 of 10 checks passed
@deleonio deleonio deleted the 7383-visual-tests---reconfigure-maxdiffpixelratio-v2 branch February 15, 2025 06:01
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant