Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor table components to enforce min-width type will be required #7381

Merged

Conversation

deleonio
Copy link
Contributor

@deleonio deleonio commented Feb 14, 2025

This pull request includes changes to the packages/components/src/schema/props/table-header-cells.ts file to simplify the code by removing unnecessary constants and hooks. The most important changes are:

Codebase simplification:

  • Removed the HEADER_CELL_WIDTH_VALIDATOR constant that was used to validate the width of a header cell.
  • Removed the afterPatch hook within the validateTableHeaderCells function that was calculating the _minWidth state based on the header cell widths.

The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer:

  • Meaningful pull request title for the release notes
  • Pull request is linked to an issue and all changes relate to the issue
  • Tests to protect this code implemented (if applicable)
  • Manual test performed successfully (if applicable)
  • Documentation or migration has been updated (if applicable)

@deleonio deleonio changed the title Remove unused header cell width validator and related logic from tabl… Refactor table components to enforce min-width type will be required Feb 14, 2025
@deleonio deleonio requested a review from laske185 February 14, 2025 11:02
Copy link
Contributor

@deleonio deleonio merged commit 3d9b37b into release/2 Feb 14, 2025
8 of 13 checks passed
@deleonio deleonio deleted the 7322-spalten-breite-als-pflicht-property-bei-tabellen-v2 branch February 14, 2025 11:17
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant