Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Combobox and Single Select to Functional Components #7373

Merged
merged 16 commits into from
Feb 12, 2025
Merged

Refactor Combobox and Single Select to Functional Components #7373

merged 16 commits into from
Feb 12, 2025

Conversation

sdvg
Copy link
Member

@sdvg sdvg commented Feb 9, 2025 •
edited
Loading

Refs: #6917

The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer:

  • Meaningful pull request title for the release notes
  • Pull request is linked to an issue and all changes relate to the issue
  • Tests to protect this code implemented (if applicable)
  • Manual test performed successfully (if applicable)
  • Documentation or migration has been updated (if applicable)

@sdvg sdvg linked an issue Feb 9, 2025 that may be closed by this pull request
single-select und combobox vereinheitlichen #6917
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2025 •
edited
Loading

Netlify Draft Deployment
URL: https://67ac589c6a553676e9d20e08--kolibri-public-ui.netlify.app
Logs: https://app.netlify.com/sites/kolibri-public-ui/deploys/67ac589c6a553676e9d20e08

sdvg and others added 6 commits February 10, 2025 12:23
@sdvg
Combobox: Implement KolFormFieldStateWrapperFc and refactor styles
97d8262 
Refs: #6917
@sdvg
Extract toggle button
a7d6dda 
Refs: #6917
@sdvg
Extract suggestion options
aa199a0 
Refs: #6917
@sdvg
Merge branch 'develop' of github.com:public-ui/kolibri into 6917-comb…
4bcaa1a 
…obox-fc

* 'develop' of github.com:public-ui/kolibri:
  Update all snapshots$ $ Refs: #7266
  Remove non-existing snapshot page
  Update all snapshots$ $ Refs: #7266
  Update sample app routes
  Implement SampleColumns for conditional grid
@sdvg
Extract suggestion options group
0941eab 
Refs: #6917
@sdvg @publicuibot
Update all snapshots$
523cdd2 
$
Refs: #6917
@sdvg sdvg changed the title Refactor Combobox to Functional Components Refactor Combobox and Single Select to Functional Components Feb 11, 2025
sdvg added 2 commits February 12, 2025 09:12
@sdvg
Fix e2e
a01cc37 
Refs: #6917
@sdvg
Merge remote-tracking branch 'origin/6917-combobox-fc' into 6917-comb…
0c3151f 
…obox-fc

* origin/6917-combobox-fc:
  Update all snapshots$ $ Refs: #6917
@sdvg sdvg marked this pull request as ready for review February 12, 2025 08:27
@deleonio deleonio merged commit 00b89ed into develop Feb 12, 2025
9 checks passed
@deleonio deleonio deleted the 6917-combobox-fc branch February 12, 2025 10:32
@github-actions github-actions bot locked and limited conversation to collaborators Feb 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deleonio deleonio deleonio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

single-select und combobox vereinheitlichen
2 participants
@sdvg @deleonio