Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table: Refactor asTd property #7364

Merged
merged 6 commits into from
Feb 7, 2025
Merged

Table: Refactor asTd property #7364

merged 6 commits into from
Feb 7, 2025

Conversation

sdvg
Copy link
Member

@sdvg sdvg commented Feb 6, 2025 •
edited
Loading

Refs: #7118

The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer:

  • Meaningful pull request title for the release notes
  • Pull request is linked to an issue and all changes relate to the issue
  • Tests to protect this code implemented (if applicable)
  • Manual test performed successfully (if applicable)
  • Documentation or migration has been updated (if applicable)

@sdvg sdvg linked an issue Feb 6, 2025 that may be closed by this pull request
Table Header Property asTd entfernen #7118
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025 •
edited
Loading

Netlify Draft Deployment
URL: https://67a5cbdb91be49435a5aa637--kolibri-public-ui.netlify.app
Logs: https://app.netlify.com/sites/kolibri-public-ui/deploys/67a5cbdb91be49435a5aa637

sdvg added 3 commits February 6, 2025 15:20
@sdvg
Refactor asTd property
f5fff84 
Refs: #7118
@sdvg
Merge remote-tracking branch 'origin/7118-table-remove-as-td' into 71…
05b857a 
…18-table-remove-as-td

* origin/7118-table-remove-as-td:
  Enable input color e2e test after upstream bug has been fixed
@sdvg
Revert "Enable input color e2e test after upstream bug has been fixed"
11368ad 
This reverts commit 54cfd78.
@sdvg sdvg changed the title Enable input color e2e test after upstream bug has been fixed Refactor asTd property Feb 6, 2025
@sdvg sdvg changed the title Refactor asTd property Table: Refactor asTd property Feb 6, 2025
@sdvg sdvg marked this pull request as ready for review February 6, 2025 14:38
deleonio
deleonio requested changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@deleonio deleonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich weiß, hier haben wir noch nicht ganz genau nach gedacht, doch so haben wir es nur umbenannt.

Wir müssen wohl einen 2. internen CellType einführen und für die Public Props soll es garnicht mehr existieren.

Oder?

sdvg added 2 commits February 7, 2025 09:33
@sdvg
Merge branch 'develop' of github.com:public-ui/kolibri into 7118-tabl…
7385225 
…e-remove-as-td

* 'develop' of github.com:public-ui/kolibri:
  Change default value of state _level property to 0
  Fix heading levels for details and accordion
  Fix import
  Remove symbol type
  Remove symbol component
  Change max, min type to number
  Remove Iso8601 from kolInputNumber value
@sdvg
Move headerCell property to internal type and remove unreachable code
1400652 
Refs: #7118
@sdvg
Copy link
Member Author

sdvg commented Feb 7, 2025

@deleonio Stimmt, da fehlte noch was. Was sagst du zu der aktuellen Lösung?

@sdvg sdvg requested a review from deleonio February 7, 2025 09:14
@deleonio deleonio merged commit 33e7c7e into develop Feb 7, 2025
9 checks passed
@deleonio deleonio deleted the 7118-table-remove-as-td branch February 7, 2025 17:15
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deleonio deleonio deleonio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Table Header Property asTd entfernen
2 participants
@sdvg @deleonio