hdf5_loader.py - psize is expected to be scalar but it might be a tuple#642
Closed
cmkewish wants to merge 2 commits intoptycho:masterfrom
Closed
hdf5_loader.py - psize is expected to be scalar but it might be a tuple#642cmkewish wants to merge 2 commits intoptycho:masterfrom
cmkewish wants to merge 2 commits intoptycho:masterfrom
Conversation
From parameter tree docs:
scandata.PtyScan.psize(float, tuple)
Detector pixel size
Dimensions of the detector pixels (in meters)
default = 0.000172 (>0.0)
psize can be a tuple... perhaps for non-square pixels, I have never used it that way but some older datasets have x,y pixel size, e.g.,
psize=[0.000172, 0.000172]
which are accepted by Ptydscan. The proposed change just (silently) uses the first element of psize.
cmkewish
commented
Nov 27, 2025
Author
cmkewish
left a comment
cmkewish
left a comment
There was a problem hiding this comment.
From parameter tree docs:
scandata.PtyScan.psize(float, tuple)
Detector pixel size
Dimensions of the detector pixels (in meters)
default = 0.000172 (>0.0)
psize can be a tuple... perhaps for non-square pixels, I have never used it that way but some older datasets have x,y pixel size, e.g.,
psize=[0.000172, 0.000172]
which are accepted by Ptydscan. The proposed change just (silently) uses the first element of psize.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From parameter tree docs:
scandata.PtyScan.psize(float, tuple)
Detector pixel size
Dimensions of the detector pixels (in meters)
default = 0.000172 (>0.0)
psize can be a tuple... perhaps for non-square pixels, I have never used it that way but some older datasets have x,y pixel size, e.g.,
psize=[0.000172, 0.000172]
which are accepted by Ptydscan. The proposed change just (silently) uses the first element of psize.