fix(postgrest-swr): preserve pagination controls during revalidation#696
Open
psteinroe wants to merge 1 commit into
Open
fix(postgrest-swr): preserve pagination controls during revalidation#696psteinroe wants to merge 1 commit into
psteinroe wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: c0160ae The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #696 +/- ##
=========================================
+ Coverage 0 92.71% +92.71%
=========================================
Files 0 151 +151
Lines 0 2415 +2415
Branches 0 763 +763
=========================================
+ Hits 0 2239 +2239
- Misses 0 145 +145
- Partials 0 31 +31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the PostgREST SWR pagination and infinite-scroll hooks so navigation controls stay available while already-loaded data is being revalidated. It also makes those controls disappear only when a newly requested page has not finished loading yet, which prevents duplicate pagination actions against incomplete state.
Behavior change:
nextPage,previousPage, andloadMoreare no longer gated byisValidatingalone. They now remain usable for stale-but-loaded data and are hidden only when the requested page for the current size/index is not yet present.API change:
useInfiniteOffsetPaginationQuerynow exposeshasNextPageandhasPreviousPagebooleans so consumers can read pagination availability without inferring it from the presence of callback helpers.The docs were updated to clarify the new control semantics, and new unit tests cover the stale-data and unloaded-page cases for both offset and cursor-based hooks.