Normalize PTY writes for PowerShell and route pastes through shared write path#1
Open
psklarkins wants to merge 1 commit intomasterfrom
Open
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
encode_text_for_pty(text: &str)and changedsend_text_to_activeto pre-encode outbound text and write the encoded bytes to PTYs so both single-pane writes andsync_inputfanout use the same byte buffer.\nand\r\ninto\rto emulate typed Enter behavior forpwsh/cmdunder ConPTY, while non-Windows retains the original bytes.send_text_to_activeinstead of writing directly to the pane.paste_latestto route throughsend_text_to_activeso paste-buffer actions benefit from the same normalization.src/input.rs,src/copy_mode.rs.Testing
cargo fmtwhich completed successfully.cargo test/cargo checkfor the native build failed due to existing platform-specific issues unrelated to these changes (Windows-only mouse constants and an unrelated symbol inserver.rs), so compilation could not be validated here.cargo check --target x86_64-pc-windows-msvcbut the Windows target toolchain is not installed in this environment so the Windows-target check could not be executed.Note: the changes are narrowly scoped to encode and route outbound text for PTY writes; the compilation failures observed during validation are due to pre-existing cross-platform build issues in this repository and not caused by the newline normalization changes.
Codex Task