Ignore Local Version in Compatibility Check #7036
Open
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to PEP 440 guidelines, the local version identifier may use the period character, however, doing so causes the compatibility check to fail as the version parsing splits on periods and unpacks to the results assuming the string follows the major, minor, patch convention. Ignoring the local version string increases the likelihood that the assumption holds. Closes: psf#7035 Signed-off-by: Bryan Fraschetti <[email protected]>
|
Quick note to explain the version parsing that I am proposing, according to PEP 440, valid versions are |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to PEP 440 guidelines, the local version identifier may use the period character, however, doing so causes the compatibility check to fail as the version parsing splits on periods and unpacks to the results assuming the string follows the major, minor, patch convention. Ignoring the local version string increases the likelihood that the assumption holds.
Closes: #7035