Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added stubs for homebrew #26

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Added stubs for homebrew #26

wants to merge 4 commits into from

Conversation

psxdev
Copy link

@psxdev psxdev commented Sep 30, 2017

We need it to properly use with homebrew

TODO incorporate all entries in all sprx stubs

@@ -2,11 +2,24 @@

#include <stdint.h>
#include <sys/time.h>
#include <sys/event.h>
Copy link

@masterzorag masterzorag Oct 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I just declare struct knote in my sample, this header give me error due forwarding declaration of struct knote;
Also, ps4sdk-examples/posix/stdio-redirect need 1 line change to compile fine now;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @masterzorag! Thanks for the feedback and help! The example can be fixed by adding #define __BSD_VISIBLE 1 before the includes.

But I would like to avoid including this header into the user-space as well. Instead of adding the include, can we use a void pointer to define SceKernelEvent? I see getter symbols for the fields of the structs, which suggests that this is the intended way of using the type. E.g. sceKernelGetEventData: SceKernelEvent -> intptr_t.

So, I would remove the sys/event.h include and use typedef void * SceKernelEvent instead. Then add the additional getters like sceKernelGetEventData

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@psxdev if you can fix the above issue I will merge the PR. Alternatively we can close it and you could add it to the libs directly (but there it should not be in /include/sce but in /include) so you will have to refactor your code. If that is ok we can close the PR - otherwise lets add the headers (after the fix above) so that for now you do not need to port your code to the new header locations.

masterzorag referenced this pull request in psxdev/liborbis Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants