PFW-1561 Fix MMU unload issue #4773
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All values in bytes. Δ Delta to base
|
gudnimg
reviewed
Sep 17, 2024
| @@ -5216,7 +5216,7 @@ static void lcd_main_menu() | |||
| MENU_ITEM_FUNCTION_P(_T(MSG_FILAMENTCHANGE), lcd_colorprint_change);//8 | |||
|
|
|||
| if (!printer_recovering()) { | |||
| if ( moves_planned() || printer_active()) { | |||
| if ( moves_planned() || printer_active() || fan_check_error == EFCE_REPORTED) { | |||
There was a problem hiding this comment.
Is this needed? 🤔 printer_active() should return true when the print is paused. If the printer is idle (not printing) then disabling fan check should be available in Settings menu.
gudnimg
reviewed
Sep 17, 2024
| } | ||
| SERIAL_ECHOLNRPGM(MSG_HOST_ACTION_CANCEL); |
There was a problem hiding this comment.
Why is this change needed? Its not really relevant to MMU unload or fan check.
…an check if needed. Send //action:cancel when LCD Stop print is selected.
3d-gussner
force-pushed
the
MK3_fix_unload
branch
from
60d2bfd
to
65a26e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Tune menu is now also available during a fan error, so the user can decide to en/disable the fan check.
Send
//action:cancelto host when Stop print is executed.Steps to reproduce:
Results:
The preferred state of printer + MMU is to have no filament loaded after a print finished or has been stopped.
Advantages:
Replaces #4771
ToDo