Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and optimise VERBOSE_CHECK_HIT_ENDSTOPS #4316

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

gudnimg
Copy link
Collaborator

@gudnimg gudnimg commented Aug 4, 2023

Make VERBOSE_CHECK_HIT_ENDSTOPS code compile again

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Target ΔFlash (bytes) ΔSRAM (bytes)
MK3S_MULTILANG 0 0
MK3_MULTILANG 0 0

@gudnimg
Copy link
Collaborator Author

gudnimg commented Aug 5, 2023

Testing this now, and for some reason I don't get these logs 🤔 I've tried Auto homing and Calibrating Z. Maybe this is only for physical endstop switches?

Looks like endstop_hit is not set at all for TMC2130

@gudnimg
Copy link
Collaborator Author

gudnimg commented Aug 5, 2023

Found a fix. We need to call checkHitEndstops() in manage_inactivity() and not loop()
image

@gudnimg gudnimg force-pushed the fix-VERBOSE_CHECK_HIT_ENDSTOPS branch from 8e3585e to 29f6a57 Compare August 5, 2023 10:58
@gudnimg gudnimg force-pushed the fix-VERBOSE_CHECK_HIT_ENDSTOPS branch from 29f6a57 to c69e028 Compare August 13, 2023 13:42
@gudnimg
Copy link
Collaborator Author

gudnimg commented Aug 13, 2023

Dropped the last commit because we cannot call checkHitEndstops() in manage_inactivity(). The reason is checkHitEndstops() clears the variable endstop_hit.

endstop_hit is used by functions endstops_hit_on_purpose, endstop_z_hit_on_purpose, enable_z_endstop, and allowing checkHitEndstops() to clear it creates more bugs.

@gudnimg gudnimg force-pushed the fix-VERBOSE_CHECK_HIT_ENDSTOPS branch from c69e028 to d545469 Compare August 13, 2023 13:44
@gudnimg gudnimg changed the title 🚧 Fix and optimise VERBOSE_CHECK_HIT_ENDSTOPS Fix and optimise VERBOSE_CHECK_HIT_ENDSTOPS Aug 13, 2023
@gudnimg gudnimg marked this pull request as ready for review August 13, 2023 13:45
@wavexx wavexx self-requested a review August 16, 2023 16:29
@3d-gussner 3d-gussner added this to the FW 3.14.0 milestone Aug 22, 2023
@3d-gussner 3d-gussner merged commit f5259ee into prusa3d:MK3 Sep 12, 2023
2 checks passed
@gudnimg gudnimg deleted the fix-VERBOSE_CHECK_HIT_ENDSTOPS branch October 7, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants