-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚧 PFW-1480 MMU: Add support for the M command #4278
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 we'll decide what to do with the stealth/normal mode after tests (hopefully we can remove the switch once for all)
marked as 🚧 : waiting for the test before we decide what to do with the Stealth/Normal mode switching |
Rebased to resolve merge conflict |
@DRracer any update? |
Rebased to sync with MK3 branch |
All values in bytes. Δ Delta to base
|
Interesting, flash usage has increased by 30 bytes 🤔 |
No, I added 🚧 until internal testing is done. Testing should find out if there is any benefit in having Stealth mode vs Normal mode switching on new MMU. There isnt as much difference now with the new firmware, but it should be tested/verified. Maybe @DRracer knows more? |
Rebased to sync with MK3 branch |
More changes are coming and back to draft
Rebased to sync with MK3 branch (96 commits) |
The M command is used to change the TMC2130 motor modes between Stealth and Normal mode.
@DRracer Please have a look at this one again. |
Important
This PR is on hold until a decision is made whether or not supporting the M command makes sense. The PR is ready for merge otherwise. If merged, this will need to be added to the MK4 as well.
The M command is used to change the TMC2130
motor modes between Stealth and Normal mode.
Note: MMU FW >3.0.0 is required since the current FW does not process the
'M'
on the protocol level. To test, you should see the below in the serial logs:Change in memory:
Flash: +76 bytes
SRAM: 0 bytes