Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 PFW-1480 MMU: Add support for the M command #4278

Closed
wants to merge 1 commit into from

Conversation

gudnimg
Copy link
Collaborator

@gudnimg gudnimg commented Jul 23, 2023

Important

This PR is on hold until a decision is made whether or not supporting the M command makes sense. The PR is ready for merge otherwise. If merged, this will need to be added to the MK4 as well.

The M command is used to change the TMC2130
motor modes between Stealth and Normal mode.

Note: MMU FW >3.0.0 is required since the current FW does not process the 'M' on the protocol level. To test, you should see the below in the serial logs:

echo:MMU2:>M1*e.      ; M1 means changing from Stealth to Normal, M0 would be opposite
echo:MMU2:<M1 A*c1.   ; Command accepted
echo:MMU2:>Q0*ea.     ; Query request
echo:MMU2:<M1 F0*d7.  ; Command finished 

Change in memory:
Flash: +76 bytes
SRAM: 0 bytes

@gudnimg gudnimg requested a review from DRracer July 23, 2023 14:21
DRracer
DRracer previously approved these changes Jul 23, 2023
Copy link
Collaborator

@DRracer DRracer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 we'll decide what to do with the stealth/normal mode after tests (hopefully we can remove the switch once for all)

@gudnimg gudnimg added this to the FW 3.13.1 milestone Jul 23, 2023
@DRracer DRracer changed the title PFW-1480 MMU: Add support for the M command 🚧 PFW-1480 MMU: Add support for the M command Jul 25, 2023
@DRracer
Copy link
Collaborator

DRracer commented Jul 25, 2023

marked as 🚧 : waiting for the test before we decide what to do with the Stealth/Normal mode switching

@gudnimg
Copy link
Collaborator Author

gudnimg commented Jul 30, 2023

Rebased to resolve merge conflict

@3d-gussner
Copy link
Collaborator

@DRracer any update?

@gudnimg
Copy link
Collaborator Author

gudnimg commented Aug 5, 2023

Rebased to sync with MK3 branch

@github-actions
Copy link

github-actions bot commented Aug 5, 2023

All values in bytes. Δ Delta to base

Target ΔFlash ΔSRAM Used Flash Used SRAM Free Flash Free SRAM
MK3S_MULTILANG 106 0 246840 5656 7112 2536
MK3_MULTILANG 106 0 246130 5663 7822 2529

@gudnimg
Copy link
Collaborator Author

gudnimg commented Aug 5, 2023

Interesting, flash usage has increased by 30 bytes 🤔

@3d-gussner
Copy link
Collaborator

@DRracer @gudnimg Can this be merged ? If so please remove 🚧

@gudnimg
Copy link
Collaborator Author

gudnimg commented Aug 7, 2023

@DRracer @gudnimg Can this be merged ? If so please remove 🚧

No, I added 🚧 until internal testing is done. Testing should find out if there is any benefit in having Stealth mode vs Normal mode switching on new MMU. There isnt as much difference now with the new firmware, but it should be tested/verified.

Maybe @DRracer knows more?

@gudnimg
Copy link
Collaborator Author

gudnimg commented Aug 20, 2023

Rebased to sync with MK3 branch

@gudnimg
Copy link
Collaborator Author

gudnimg commented Sep 14, 2023

Rebased to sync with MK3 branch (96 commits)

@3d-gussner 3d-gussner added the MMU MMU2s and MMU3 label Oct 20, 2023
@3d-gussner 3d-gussner removed this from the FW 3.14.0 milestone Nov 17, 2023
The M command is used to change the TMC2130
motor modes between Stealth and Normal mode.
@gudnimg gudnimg added this to the FW 3.14.1 milestone Jan 21, 2024
@3d-gussner
Copy link
Collaborator

@DRracer Please have a look at this one again.

@3d-gussner 3d-gussner removed this from the FW 3.14.1 milestone Apr 30, 2024
@gudnimg gudnimg removed the in progress We are working on solving this one label Jul 31, 2024
@gudnimg gudnimg closed this Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MMU MMU2s and MMU3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants