Polls #179
Polls #179
Conversation
…tration add meeting registrant apis
Add panelist api
prschmid
left a comment
prschmid
left a comment
There was a problem hiding this comment.
Thank you for this PR and our work to expand this library! I've added in a couple of comments for minor fixes. Looking forward to merging this in.
Thanks!
| responses.add( | ||
| responses.POST, "http://foo.com/webinar/ID/panelists", | ||
| ) | ||
| response = self.component.add_panelists(panelists=[{"name": "Mary", "email": "[email protected]"}]) |
There was a problem hiding this comment.
Can you make this a more human readable email? Maybe[email protected]?
| ) | ||
| response = self.component.add_panelists(panelists=[{"name": "Mary", "email": "[email protected]"}]) | ||
| self.assertEqual( | ||
| response.request.body, '{panelists: [{"name": "Mary", "email": "[email protected]"}]}' |
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| unittest.main() No newline at end of file |
There was a problem hiding this comment.
Did you run black to check for formatting? Looks like some files are missing a newline at the end.
| ) | ||
| response = self.component.delete_panelists(panelists=[{"name": "Mary", "email": "[email protected]"}]) | ||
| self.assertEqual( | ||
| response.request.body, '{panelists: [{"name": "Mary", "email": "[email protected]"}]}' |
There was a problem hiding this comment.
See previous comment regarding email
zoomus/__init__.py
Outdated
|
|
||
| __all__ = ["API_VERSION_1", "API_VERSION_2", "ZoomClient"] | ||
| __version__ = "1.1.3" | ||
| __version__ = "1.1.4" |
There was a problem hiding this comment.
Please revert this change and leave it as 1.1.3 -- I'll update it to the appropriate version when I cut the next release (which likely will be 1.1.6).
zoomus/components/__init__.py
Outdated
| from __future__ import absolute_import | ||
|
|
||
| from . import meeting, metric, past_meeting, phone, recording, report, user, webinar | ||
| from . import meeting, metric, past_meeting, phone, recording, report, user, webinar, poll |
There was a problem hiding this comment.
Can you add the poll in the correct alphabetical order? I.e. after phone. Thanks!
zoomus/components/poll.py
Outdated
| def list(self, **kwargs): | ||
| util.require_keys(kwargs, "id") | ||
| return self.get_request( | ||
| f"/{self.type}/{kwargs.get('id')}/polls" |
There was a problem hiding this comment.
Looks like in some cases you are using f"...." and in others "...".format(). Since the rest of the library uses the "...".format() syntax, can you please switch it to that for consistency's sake?
There was a problem hiding this comment.
Sure, I have changed the f"...."and in this "...".format()
|
@vishnuku Thank you for this PR! We merged in some code that it appears you based your work off of. Can I trouble you to resolve the conflicts so that we can get this merged? Thank you for your time and effort! |
Hi @mfldavidson , I will complete these on this weekend. Thanks for reminding |
@vishnuku no problem, we really appreciate your work on this! |
4 participants
Add poll functionality for meeting and webinars