Skip to content

Feat: Support creating warmed VM in the proxy wasm V8 VM API. #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Feat: Support creating warmed VM in the proxy wasm V8 VM API. #447

wants to merge 2 commits into from
+22 −1

Conversation

rachgreen33
Copy link
Contributor

No description provided.

@mpwarres
Copy link
Contributor

mpwarres commented Aug 1, 2025

Looks like you need to add no-op implementations of warm() to other subclasses of WasmVm to fix the current build failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PiotrSikora PiotrSikora Awaiting requested review from PiotrSikora PiotrSikora will be requested when the pull request is marked ready for review PiotrSikora is a code owner

@martijneken martijneken Awaiting requested review from martijneken martijneken will be requested when the pull request is marked ready for review martijneken is a code owner

@mpwarres mpwarres Awaiting requested review from mpwarres mpwarres will be requested when the pull request is marked ready for review mpwarres is a code owner

@leonm1 leonm1 Awaiting requested review from leonm1 leonm1 will be requested when the pull request is marked ready for review leonm1 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rachgreen33 @mpwarres