Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(report): remove invalid resources in report #6852

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MrCloudSec
Copy link
Member

@MrCloudSec MrCloudSec commented Feb 6, 2025

Context

Fix #6742 and #6728

Description

Remove invalid resources in Check Report in some checks.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MrCloudSec MrCloudSec requested review from a team as code owners February 6, 2025 15:45
@MrCloudSec MrCloudSec added the backport-to-v5.2 Backport PR to the v5.2 branch label Feb 6, 2025
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Feb 6, 2025
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.73%. Comparing base (665bfa2) to head (3e33aef).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6852      +/-   ##
==========================================
- Coverage   88.74%   88.73%   -0.02%     
==========================================
  Files        1200     1200              
  Lines       34611    34609       -2     
==========================================
- Hits        30716    30710       -6     
- Misses       3895     3899       +4     
Flag Coverage Δ
prowler 88.73% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler 88.73% <100.00%> (-0.02%) ⬇️
api ∅ <ø> (∅)

Copy link
Member

@jfagoagas jfagoagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several things from the changes:

  • Is it possible to create a resource_metadata instead of passing an empty dict?
  • Could you please assert in all the tests affecting these checks the content of the resource metadata?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-v5.2 Backport PR to the v5.2 branch provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Several resources cannot be converted to dict to be included in the report.resource
2 participants