fix(detect-secrets): add case for non utf-8 values #6758
Closed
+99
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Partially Fixes #6728
Description
This pull request includes updates to handle cases where environment variables containing secrets are not found, by providing a default value of 'UNKNOWN'. Additionally, new test cases have been added to verify these changes.
Error handling improvements:
prowler/providers/aws/services/awslambda/awslambda_function_no_secrets_in_variables/awslambda_function_no_secrets_in_variables.py
: Updated the secret detection logic to return 'UNKNOWN' if the environment variable is not found.prowler/providers/aws/services/ecs/ecs_task_definitions_no_environment_secrets/ecs_task_definitions_no_environment_secrets.py
: Modified the secret detection logic to return 'UNKNOWN' if the environment variable is not found.New test cases:
tests/providers/aws/services/awslambda/awslambda_function_no_secrets_in_variables/awslambda_function_no_secrets_in_variables_test.py
: Added a test case to ensure that 'UNKNOWN' is returned when the environment variable is not found.tests/providers/aws/services/ecs/ecs_task_definitions_no_environment_secrets/ecs_task_definitions_no_environment_secrets_test.py
: Added a test case to verify that 'UNKNOWN' is returned when the environment variable is not found.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.