Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(detect-secrets): add case for non utf-8 values #6758

Closed

Conversation

pedrooot
Copy link
Member

@pedrooot pedrooot commented Jan 30, 2025

Context

Partially Fixes #6728

Description

This pull request includes updates to handle cases where environment variables containing secrets are not found, by providing a default value of 'UNKNOWN'. Additionally, new test cases have been added to verify these changes.

Error handling improvements:

New test cases:

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@pedrooot pedrooot requested review from a team as code owners January 30, 2025 16:22
@github-actions github-actions bot added the provider/aws Issues/PRs related with the AWS provider label Jan 30, 2025
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.74%. Comparing base (627c115) to head (184cdec).
Report is 41 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6758      +/-   ##
==========================================
- Coverage   88.75%   88.74%   -0.01%     
==========================================
  Files        1195     1195              
  Lines       34488    34488              
==========================================
- Hits        30610    30607       -3     
- Misses       3878     3881       +3     
Flag Coverage Δ
prowler 88.74% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler 88.74% <ø> (-0.01%) ⬇️
api ∅ <ø> (∅)

@jfagoagas jfagoagas added the backport-to-v5.2 Backport PR to the v5.2 branch label Jan 31, 2025
@pedrooot
Copy link
Member Author

pedrooot commented Feb 7, 2025

Closed by #6710

@pedrooot pedrooot closed this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-v5.2 Backport PR to the v5.2 branch provider/aws Issues/PRs related with the AWS provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS - AttributeError on generating report
2 participants