chore: remove specific overwriting

protobufjs · Oct 8, 2024 · 1f1d33c · 1f1d33c
1 parent caad500
commit 1f1d33c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/object.js b/src/object.js
@@ -243,11 +243,11 @@ ReflectionObject.prototype.setParsedOption = function setParsedOption(name, valu
             // If we found an existing option - just merge the property value
             // (If it's a feature, will just write over)
             var newValue = opt[name];
-            util.setProperty(newValue, propName, value, isFeature);
+            util.setProperty(newValue, propName, value);
         } else {
             // otherwise, create a new option, set its property and add it to the list
             opt = {};
-            opt[name] = util.setProperty({}, propName, value, isFeature);
+            opt[name] = util.setProperty({}, propName, value);
             parsedOptions.push(opt);
         }
     } else {

diff --git a/src/util.js b/src/util.js
@@ -174,7 +174,7 @@ util.decorateEnum = function decorateEnum(object) {
  * @param {boolean} overWrite whether or not to concatenate the values into an array or overwrite; defaults to false.
  * @returns {Object.<string,*>} Destination object
  */
-util.setProperty = function setProperty(dst, path, value, overWrite = false) {
+util.setProperty = function setProperty(dst, path, value) {
     function setProp(dst, path, value) {
         var part = path.shift();
         if (part === "__proto__" || part === "prototype") {
@@ -184,7 +184,7 @@ util.setProperty = function setProperty(dst, path, value, overWrite = false) {
             dst[part] = setProp(dst[part] || {}, path, value);
         } else {
             var prevValue = dst[part];
-            if (prevValue && !overWrite)
+            if (prevValue)
                 value = [].concat(prevValue).concat(value);
             dst[part] = value;
         }