refactor: skip foreign keys and inverse edges when marshaling JSON #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Howard <[email protected]>
jhoward-lm
added
enhancement
jhoward-lm
requested review from
fkautz,
eddiezane,
puerco,
cpanato and
veramine
Signed-off-by: Jonathan Howard <[email protected]>
puerco
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the struct tags of the generated ent types and adds a custom
MarshalJSONmethod for each. This change is mostly cosmetic, but it aligns more closely with the original protobom structure when marshaled to JSON.Note
Only the following files are manually modified; the rest are auto-generated
internal/backends/ent/schema/*.gointernal/backends/ent/template/jsonencode.tmplinternal/backends/ent/entc.go/cc @ashearin @lmphil @pkwiatkowski1 @Strakeln @jmayer-lm @EphraimEM