refactor: redefine annotation document ID as nillable/pointer type #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoward-lm
added
enhancement
jhoward-lm
requested review from
fkautz,
eddiezane,
puerco,
cpanato and
veramine
jhoward-lm
force-pushed
the
annotations-nillable-document-id
branch
from
91ba173 to
bcaeb1d
Compare
jhoward-lm
force-pushed
the
annotations-nillable-document-id
branch
from
bcaeb1d to
7d24206
Compare
Signed-off-by: Jonathan Howard <[email protected]>
jhoward-lm
force-pushed
the
annotations-nillable-document-id
branch
from
7d24206 to
73c04b1
Compare
puerco
approved these changes
Jan 16, 2025
ashearin
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR redefines the
Annotationschema'sdocument_idas nillable. This allows clearer delineation between document-specific and node-specific annotations, and the intent is to enable future enhancements (utilize edge-schema to truly separate node/document annotations).Diff against previous branch in the PR series: link
Depends on #56
Note
Only the following files are manually modified; the rest are auto-generated
backends/ent/*.gointernal/backends/ent/schema/*.go/cc @ashearin @lmphil