-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing code on mypy errors #721
Conversation
Is dmypy usefull? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the remark about the API is a nit.
Use mypy api to get the messages details before: ``` prospector/blender.py:81:13: error(mypy): List comprehension has incompatible type List[Message]; expected List[str] [misc] prospector/blender.py:101:12: error(mypy): Incompatible return value type (got "list[str]", expected "list[Message]") [return-value] ``` after: ``` prospector/blender.py:81:12: misc(mypy): List comprehension has incompatible type List[Message]; expected List[str]. prospector/blender.py:101:11: return-value(mypy): Incompatible return value type (got "list[str]", expected "list[Message]"). ```
@Pierre-Sassoulas can't we merge as it and restore the Pylint configuration when the astroid fix is available? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
Thanks :-) |
Use mypy api to get the messages details
before:
after:
Description
Use the json formater, use the API to get the message individually.
Related Issue
fix #716
Motivation and Context
Have a better mypy integration
How Has This Been Tested?
Run on Prospector code with some errors
Types of changes