feat: add Alien Base V3 encoder for Base#335
Open
Haikane wants to merge 2 commits into
Open
Conversation
Register alienbase_v3 protocol system with UniswapV3SwapEncoder, reusing the existing V3 executor on Base. Alien Base V3 uses stock Uniswap V3 core contracts, so the same executor and encoder work without modification. Differential testing confirms identical swap math (0-2 wei rounding on WETH/USDC and ALB/WETH pools). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3 tasks
Add alienbase_v3 to CALLBACK_CONSTRAINED_PROTOCOLS (bug fix: V3 forks use callback-based token transfers, without this multi-hop routes would have incorrect transfer handling). Add comment to shared match arm explaining why pancakeswap_v3 and alienbase_v3 share the UniswapV3SwapEncoder. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Haikane
changed the title
5 tasks
dianacarvalho1
left a comment
dianacarvalho1
left a comment
Collaborator
There was a problem hiding this comment.
Thank you! If everything looks (sdk tests) then you can go ahead and deploy the executor (you need to set the correct factory and etc). Then we can set it and record the real address in config/executor_addresses.json. Then we need to set it in the router
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
alienbase_v3protocol system withUniswapV3SwapEncoderin the encoder registryalienbase_v3on Base chain (reuses existing V3 executor0x647bffbf8bd72bf6341ecba8b0279e090313a40d)Changes
swap_encoder_registry.rs: Add"alienbase_v3"to thepancakeswap_v3match arm (both are V3 forks)executor_addresses.json: Addalienbase_v3entry forbasechainVerification
cargo checkandcargo clippycleanRelated PRs
Test plan
cargo checkpasses🤖 Generated with Claude Code