Update prombench/benchmark manifests
#727
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vandit Singh <[email protected]>
Signed-off-by: Vandit Singh <[email protected]>
|
Why do we have two configmaps for promtail that look very similar? |
|
Why is it running 3 promtails? This seems unnecessary. |
|
This one is to get the logs from each node via tha daemonset https://github.com/prometheus/test-infra/blob/master/prombench/manifests/cluster-infra/6d_promtail_daemon_set.yaml#L34 This promtail has two deployments because for when testing PR and One for testing against a Release. Is there a way to have this deployment conditonally? |
|
The DaemonSet only runs on one node, due to https://github.com/prometheus/test-infra/blob/master/prombench/manifests/cluster-infra/6d_promtail_daemon_set.yaml#L124 It’s unnecessary to have all this complication; I’ll fix it. |
I'll update it to the latest. |
Signed-off-by: Vandit Singh <[email protected]>
Signed-off-by: Vandit Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I have
3.0.0