Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix manifest failures and other small errors while deploying the application #722

Conversation

Vandit1604
Copy link
Contributor

@Vandit1604 Vandit1604 commented Aug 13, 2024

fixes #721
fixes #715

With the changes in this PR, I was able to deploy the project and use it. It is still giving some deprecation warnings and unhealthy promtail warning. I'll address them in another pull request.

@Vandit1604 Vandit1604 force-pushed the fix/update-kube-state-metrics-unknown-configuration-flag branch from 1c311f4 to 9e6f2a6 Compare August 15, 2024 19:49
@Vandit1604 Vandit1604 changed the title Fix unknown configuration flag in kube-state-metrics manifest file Fix manifest failures and other small errors while deploying the application Aug 15, 2024
Copy link
Member

@jesusvazquez jesusvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you Vandit

@jesusvazquez jesusvazquez merged commit 6c417c5 into prometheus:master Aug 18, 2024
4 checks passed
@Vandit1604 Vandit1604 deleted the fix/update-kube-state-metrics-unknown-configuration-flag branch August 18, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants