-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Validating Webhook Configuration resource in K8s package #719
Support Validating Webhook Configuration resource in K8s package #719
Conversation
8c798bd
to
4cfb338
Compare
…urations Signed-off-by: Vandit Singh <[email protected]>
4cfb338
to
7bda4bc
Compare
I guess circleci failed because of my committed |
I've encountered an error while applying a ValidatingWebhookConfiguration:
It seems related to missing resourceVersion during an update. |
var exists bool | ||
for _, l := range list.Items { | ||
if l.Name == req.Name { | ||
exists = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think adding the following code can resolve the issue
if req.ResourceVersion == "" {
req.ResourceVersion = l.ResourceVersion
}
Thanks @yomek33 for pointing this out. |
Signed-off-by: Vandit Singh <[email protected]>
Updated with changes. Thanks @yomek33 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM very related to your previous change in #716
…ions Signed-off-by: Jesus Vazquez <[email protected]>
fixes: #718
We aren't supporting
ValidatingWebhookConfiguration
but using it in our cluster-infra manifest files for prombench.