Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prombench: Fix kind docs #658

Merged
merged 1 commit into from
Apr 1, 2024
Merged

prombench: Fix kind docs #658

merged 1 commit into from
Apr 1, 2024

Conversation

aknuds1
Copy link
Contributor

@aknuds1 aknuds1 commented Mar 29, 2024

Some kind docs fixes:

  • Fix heading "Create the Cluster Cluster" => "Create the KIND Cluster"
  • Fix control plane taint name (I found this out by trying to apply the procedure): "node-role.kubernetes.io/master" => "node-role.kubernetes.io/control-plane"
  • Modify kubectl commands to include --context kind-$CLUSTER_NAME, as you otherwise have to make this the default cluster

@aknuds1
prombench: Fix kind docs
a7e0b9a 
Signed-off-by: Arve Knudsen <[email protected]>
@aknuds1 aknuds1 added prombench docs Pull requests that update docs labels Mar 29, 2024
jesusvazquez
jesusvazquez approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@jesusvazquez jesusvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jesusvazquez jesusvazquez merged commit e1c8df0 into master Apr 1, 2024
4 checks passed
@jesusvazquez jesusvazquez deleted the arve/fix-kind-docs branch April 1, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesusvazquez jesusvazquez jesusvazquez approved these changes

Assignees
No one assigned
Labels
docs Pull requests that update docs prombench
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aknuds1 @jesusvazquez