Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use Go standard errors #619

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

use Go standard errors #619

wants to merge 1 commit into from

Conversation

mmorel-35
Copy link

  • Since Dec 1, 2021, github.com/pkg/errors is an archived project.
  • Since go 1.13, there is a standard errors and fmt modules that provides equivalent ways to handle errors.

Signed-off-by: Matthieu MOREL [email protected]

@mmorel-35
use Go standard errors
11dfb5d 
Signed-off-by: Matthieu MOREL <[email protected]>
@mmorel-35
Copy link
Author

Anything left to merge this ?

bboreham
bboreham reviewed Jan 15, 2024
View reviewed changes
Copy link
Member

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible to me, but I am not familiar with the code.

It seems some more linting was turned on, which prompted some other, mostly cosmetic, changes. I always look for consistency between the description and the diffs, since it can reveal changes included by mistake.

tools/fake-webserver/server.go
Comment on lines +91 to +92
"/api/foo": {
"GET": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change doesn't seem covered by the PR or commit description.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's gofumpt simplifying code.

@mmorel-35 mmorel-35 marked this pull request as draft January 15, 2024 21:54
@mmorel-35
Copy link
Author

I'll narrow this to fit title and provide another PR for the formarring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bboreham bboreham bboreham left review comments

@metalmatze metalmatze metalmatze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmorel-35 @metalmatze @bboreham