Fixing nginx issue: #556
Merged
Fixing nginx issue: #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
saketjajoo
commented
Jun 16, 2023
saketjajoo
commented
- Updating apiGroups, resources and verbs in ClusterRole.
- Moving the svc before deployment (as the deployment expects the svc to be already created beforehand).
- Updating the security context of user to 101 (runAsUser: 101 in 0.27.1 image kubernetes/ingress-nginx#4942).
- Upgrading the nginx image version to 0.33.0.
maxamins
reviewed
Jun 20, 2023
prombench/manifests/cluster-infra/2_ingress-nginx-controller.yaml
Outdated
Show resolved
Hide resolved
maxamins
approved these changes
Jun 21, 2023
maxamins
suggested changes
Jun 21, 2023
There was a problem hiding this comment.
Please rebase based on HEAD. so commit Update GKE Node pool base image doesn't show up as part of your PR.
- Updating apiGroups, resources and verbs in ClusterRole.
- Moving the svc before deployment (as the deployment expects the svc to
be already created beforehand).
-- Note: This may have worked in the past as a one-off patch to the
deployment. And since the main node (and its deployments) is not created for every
benchmark run, this may not have caused an issue.
- Updating the security context of user to 101 (kubernetes/ingress-nginx#4942).
- Upgrading the nginx image version to 0.33.0.
Signed-off-by: saketjajoo <[email protected]>
maxamins
approved these changes
Jun 21, 2023
|
c.c: @bwplotka - Can you please review and approve this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.