nvme: add namespace parameters #3360
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shashwat Hiregoudar <[email protected]>
Signed-off-by: Shashwat Hiregoudar <[email protected]>
Author
Member
|
Could you try to add tests for the new metrics? |
Signed-off-by: Shashwat Hiregoudar <[email protected]>
Signed-off-by: Shashwat Hiregoudar <[email protected]>
Signed-off-by: Shashwat Hiregoudar <[email protected]>
Author
|
I have updated the fixtures and the output.txt. |
Member
|
Seems reasonable but parsing should go into the prometheus/procfs module |
Author
|
Ok 👍 prometheus/procfs#765 please approve it |
Author
|
After they are merged, i can apply this patch and update the go.mod file with the new release tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement of the NVMe collector in node-exporter, to include the below-mentioned NVMe namespace-specific parameters NUSE
NCAP
NSZE
LBA Size
ANA State