-
Couldn't load subscription status.
- Fork 800
sys.user_summary: Fix handling of negative current_memory values #985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
MySQL's sys.user_summary.current_memory column can contain negative values when memory is freed faster than allocated. This is valid MySQL behavior. Changes: - Changed current_memory type from uint64 to int64 - Added test case with negative current_memory value (-16360) Fixes scan error: 'converting driver.Value type []uint8 to uint64: invalid syntax' Signed-off-by: Ali Maleki <[email protected]>
|
Related to #982 |
|
If you are going to use LLMs to write PRs, please include this information in the PR description. |
|
I am unable to find any evidence in the MySQL documentation about why this happens. This smells like an LLM hallucination. Regardless, it's clear that the column schema is int64 and we need to handle the negative case. |
|
Thanks for reviewing. link url: |
|
That is for a completely different feature within the documentation. While it may be true that this is what is happening, the documentation does NOT make this conclusive or clear. Please do not use LLMs to write PR descriptions. The statement of fact in the description is not written by you and is completely made up. |
Did you actually test this? Or is this another made up LLM output? |
|
After applying the fix, I’m currently using the fixed version without any issues. Am I misunderstanding something here? Is this not considered an issue, or should I proceed with submitting a new PR for this change, or would you prefer to handle the update on your side? @SuperQ Again, I revert the version to show you the real error So I use my fix version to not get this error ^^^ |
|
Thanks for confirming. The issues is it's difficult to tell if the issue is really fixed because of your use of LLMs. |
|
Thanks for your time and review @SuperQ |
MySQL's sys.user_summary.current_memory column can contain negative values
when memory is freed faster than allocated. This is valid MySQL behavior.
Changes:
Fixes scan error: 'converting driver.Value type []uint8 to uint64: invalid syntax'
Signed-off-by: Ali Maleki [email protected]