feat(om2): classic histogram and summary as complex types #2679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krajorama
changed the title
Ref: prometheus/OpenMetrics#283 Signed-off-by: György Krajcsovits <[email protected]>
krajorama
force-pushed
the
krajo/om2.0-complex-hist-summ
branch
from
aca6583 to
4c7a987
Compare
Signed-off-by: György Krajcsovits <[email protected]>
krajorama
commented
Jun 16, 2025
The timestamp requirement came from current limitations in Prometheus exemplar storage. However in the future this might be solved. Also there's the case when a classic histogram exposes exemplars. Signed-off-by: György Krajcsovits <[email protected]>
dashpole
approved these changes
Jun 17, 2025
| Complex data types MUST contain all information necessary to recreate a sample of a Metric Type, with the exception of Created Value and Exemplars. | ||
|
|
||
| List of complex data types: | ||
| - Integer counter classic histogram for the Metric Type Histogram. |
There was a problem hiding this comment.
nit: are these float histograms, rather than integer histograms?
bwplotka
approved these changes
Sep 4, 2025
There was a problem hiding this comment.
I would love that, but as we discussed on our sync - we need a bigger decision if we want to follow this path.
If we do, we likely need some rough uncomplex inlined format explained that is not meant to be used for scraping and can be surfaced with promtool etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: prometheus/OpenMetrics#283
It isn't hard to come up with a representation, based on previous work in https://github.com/prometheus/proposals/blob/main/proposals/2024-01-29_native_histograms_text_format.md .