chore(ci): Add CRLF detection and fix targets to prevent CRLF contamination #1898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nation Add two new Makefile targets to detect and fix carriage return (CRLF) line endings that can contaminate the codebase from Windows environments: - check-crlf: Scans all text files (excluding hidden dirs and vendor) for CRLF line endings and fails if any are found - fix-crlf: Automatically converts CRLF to LF using the tr command Add CRLF check to CI workflow to catch line ending issues early in PRs. The check runs immediately after checkout, before any other validation. Also rename go.yml to validate.yml to better reflect the workflow's purpose, and fix job name casing (supportedVersions -> supported_versions). Signed-off-by: Kemal Akkoyun <[email protected]>
kakkoyun
requested review from
ArthurSens,
bwplotka and
vesari
as code owners
bwplotka
approved these changes
Oct 28, 2025
| steps: | ||
| - name: Checkout code | ||
| --- | ||
| name: Validate |
There was a problem hiding this comment.
Can we keep Go name (also in file)? Otherwise we need to change GH CI required checks and generally change the experience of contributing to client_golang. Is it worth the name change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two new Makefile targets to detect and fix carriage return (CRLF)
line endings that can contaminate the codebase from Windows environments:
for CRLF line endings and fails if any are found
Add CRLF check to CI workflow to catch line ending issues early in PRs.
The check runs immediately after checkout, before any other validation.
Also rename go.yml to validate.yml to better reflect the workflow's
purpose, and fix job name casing (supportedVersions -> supported_versions).
Signed-off-by: Kemal Akkoyun [email protected]