Use cloned http.DefaultTransport. issue-1857 #1885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karthik Kondapally <[email protected]>
karthikkondapally
requested review from
ArthurSens,
bwplotka,
kakkoyun and
vesari
as code owners
Signed-off-by: Karthik Kondapally <[email protected]>
|
cc @bwplotka |
|
Tansport.clone has issues with Http2 and is mentioned in this golang/go#39302 and even 1.24 has issues golang/go#39302(comment) , |
…riables Signed-off-by: Karthik Kondapally <[email protected]>
|
LGTM, sorry for test failures, it's being fixed in #1892 (you can help us figure things out too 🙃 e.g. why it happened) |
yeah, I think metrics were generated on sep 1 but on oct 7, 8 this new metric "httpcookiemaxnum" got added for versions 1.24 and 1.25. May be that is the issue? and this PR 1892 fixes it ? |
|
Yes, we just merged it. Do you mind rebasing? |
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1857
with standard fallback configuration