Skip to content

fix: client prompt return on context cancellation #1729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

umegbewe
Copy link

@umegbewe umegbewe commented Feb 3, 2025

This fixes the issue where the client blocks for the entire duration of the response stream, even when the provided context had already been canceled or times out

Relevant issue #1698

Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some questions, not sure if this will work. My understanding was that we have to manually chunk reads from the resp.Body.

@kakkoyun kakkoyun requested a review from bwplotka April 10, 2025 08:27
@kakkoyun
Copy link
Member

@umegbewe The PR need to rebase.
I have also pinged @bwplotka to have another look at it.

@umegbewe umegbewe force-pushed the fix/client-context-canceled branch from 9e16398 to 9a59353 Compare April 29, 2025 12:59
Signed-off-by: Umegbewe Nwebedu <[email protected]>
Signed-off-by: Umegbewe Nwebedu <[email protected]>
@umegbewe
Copy link
Author

@bwplotka @kakkoyun updated, PR is good to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants