Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add dependabot #176

Merged
merged 1 commit into from
Oct 15, 2023
Merged

ci: add dependabot #176

merged 1 commit into from
Oct 15, 2023

Conversation

resmo
Copy link
Contributor

@resmo resmo commented Oct 13, 2023

Ensure we update github actions and don't miss image releases (I am not sure if it will work they way we use args in dockerfile for the version.

@znerol
Copy link
Member

znerol commented Oct 14, 2023

Thanks. According to the dependabot docker docs we also need to add the following line to the Dockerfile:

LABEL org.opencontainers.image.source="https://github.com/prometheus-pve/prometheus-pve-exporter/"

The docs also mentions that tags need to be in the same format on the git repo as well as in the image registry. Unfortunately we are using vX.Y.Z on the repo and X.Y.Z in the image registry. Guess we have to decide whether we change one or the other.

Regarding the base image version arg in the docker image. I'm open to drop those bits. I cannot imagine a use case where supplying a different base image version via build args would simplify anything.

@resmo
Copy link
Contributor Author

resmo commented Oct 15, 2023

I think there is a misunderstanding: the images we depend on must fulfill the requirements you described. Our image doesn't have to.

Copy link
Member

@znerol znerol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's see what happens.

@resmo resmo merged commit 4ce25d2 into main Oct 15, 2023
1 check passed
@resmo resmo deleted the test/dependabot branch October 15, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants