Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-blackbox-exporter] Remove toYaml from extraManifests template #5035

Closed

Conversation

iandrewt
Copy link
Contributor

@iandrewt iandrewt commented Dec 2, 2024

This allows the resources defined via the extraManifests value to have more 'helm-like' layouts when doing templating within them, such as having the template on the line beneath labels below:

extraManifests:
  - apiVersion: v1
     kind: MyCRD
     metadata:
       labels:
         {{- include "prometheus-blackbox-exporter.labels" . | nindent 4 }}

What this PR does / why we need it

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer

This is a repeat of #4220, which was abandoned.

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

Copy link

stale bot commented Feb 1, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale label Feb 1, 2025
Copy link

stale bot commented Feb 25, 2025

This issue is being automatically closed due to inactivity.

@stale stale bot closed this Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[prometheus-blackbox-exporter] include in extra-manifests.yaml
1 participant