Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-smartctl-exporter] Add support for device-include / device-exclude and image pull secrets #4990

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jmif
Copy link

@jmif jmif commented Nov 11, 2024

What this PR does / why we need it

Adds image pull secret support and device regex support to smartctl monitor

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

@jmif jmif requested a review from zeritti as a code owner November 11, 2024 02:48
@jmif jmif changed the title [prometheus-couchdb-exporter] Add support for device-include / device-exclude and image pull secrets [prometheus-smartctl-exporter] Add support for device-include / device-exclude and image pull secrets Nov 11, 2024
Copy link
Member

@zeritti zeritti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @jmif, for your PR. Please, see my comments below.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants