[prometheus-blackbox-exporter] Adjust configPath handling #4915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakob Hahn <[email protected]>
Jakob3xD
requested review from
desaintmartin,
gianrubio,
monotek and
rsotnychenko
as code owners
Signed-off-by: Jakob Hahn <[email protected]>
monotek
requested changes
Nov 6, 2024
| {{- else }} | ||
| - "--config.file=/etc/blackbox_exporter/config.yml" | ||
| {{- end }} | ||
| - --config.file={{ .Values.configPath | default "/config/blackbox.yaml" }} |
There was a problem hiding this comment.
As this is a major updat anyway we might think about to rename the var to .Values.configFile too.
Imho this fits better as the var currently contains a filename and not only the path.
Thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Issue
I want to deploy the config map for the Blackbox config on my own, as I want to write some logic that adjust the ConfigMap more dynamically. Therefore I need to
nulltheconfigvalue as otherwise the ConfigMap is created with the default chart values. When settingconfigtonullthe config path is set to/etc/blackbox_exporter/config.ymlwhich does not exist.Changes
I changed the config path logic to match the one of the config reloader. If no
configPathis set, we use the default of/config/blackbox.yamlotherwise we use theconfigPathvalue. The default value of/etc/blackbox_exporter/config.ymlgets removed as I don´t see the point in keeping it. If needed it can be set viaconfigPath.As it its a breaking change, I also bumped the version.
Which issue this PR fixes
None
Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])