-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[prometheus-blackbox-exporter] Adjust configPath handling #4915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[prometheus-blackbox-exporter] Adjust configPath handling #4915
Conversation
{{- else }} | ||
- "--config.file=/etc/blackbox_exporter/config.yml" | ||
{{- end }} | ||
- --config.file={{ .Values.configPath | default "/config/blackbox.yaml" }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is a major update anyway we might think about to rename the var to .Values.configFile
too.
Imho this fits better as the var currently contains a filename and not only the path.
Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am really sorry for the late response. I lost track of the PR.
You are correct, that naming it configPath would match its actual purpose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But the file does exist in the docker image: https://github.com/prometheus/blackbox_exporter/blob/master/Dockerfile#L9C1-L9C49
So i would keep the old default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, I was looking at the wrong container (config reloader).
I'll close the PR. However, I am asking if config reloader should be removed if no config and no config Path is set, as it wouldn't do anything.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
Signed-off-by: Jakob Hahn <[email protected]>
Signed-off-by: Jakob Hahn <[email protected]>
Signed-off-by: Jakob Hahn <[email protected]>
04baa2b
to
b6a7af0
Compare
What this PR does / why we need it
Issue
I want to deploy the config map for the Blackbox config on my own, as I want to write some logic that adjust the ConfigMap more dynamically. Therefore I need to
null
theconfig
value as otherwise the ConfigMap is created with the default chart values. When settingconfig
tonull
the config path is set to/etc/blackbox_exporter/config.yml
which does not exist.Changes
I changed the config path logic to match the one of the config reloader. If no
configPath
is set, we use the default of/config/blackbox.yaml
otherwise we use theconfigPath
value. The default value of/etc/blackbox_exporter/config.yml
gets removed as I don´t see the point in keeping it. If needed it can be set viaconfigPath
.As it its a breaking change, I also bumped the version.
Which issue this PR fixes
None
Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter]
)