Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add conditionally support new table panels #4829

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

acazenave
Copy link

Add this fix https://github.com/prometheus-community/helm-charts/pull/4297/files to k8s-resources-node.yaml

Sorry if I'm not fully respecting the process, it's my first PR so please be indulgent.

@jkroepke
Copy link
Member

jkroepke commented Sep 8, 2024

It should be fixed upstream.

https://github.com/kubernetes-monitoring/kubernetes-mixin/blob/50150c585ebee6e4d9cb72218182da8f3c616515/dashboards/resources/node.libsonnet#L72C116-L72C121

The grafana.sidecar.dashboards.enableNewTablePanelSyntax will be removed soon.

@QuentinBisson
Copy link
Member

QuentinBisson commented Oct 10, 2024

Hey @acazenave Thank you for your PR. Do you think you could push this upstream and close this PR? Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants