Allow clients to explicitly dismiss kill switch via Bellerophon manager #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominicancrum
force-pushed
the
feature/explicitly-dismiss-kill-switch
branch
from
cf9b0e0 to
eb22bdb
Compare
| @@ -105,6 +105,16 @@ public class BellerophonManager: NSObject { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| public func dismissKillSwitchIfNeeded() { | |||
There was a problem hiding this comment.
The name isn't very explicit, maybe keep this function internal, and create a new public function with a more descriptive name that calls this one?
There was a problem hiding this comment.
@dominicancrum any updates on this PR?
There was a problem hiding this comment.
With the recent changes to the kill switch I think this can actually be closed @ThibaultKlein
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.