-
Notifications
You must be signed in to change notification settings - Fork 989
Benchmarks documentation #2764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Benchmarks documentation #2764
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know I needed this until I saw this, its nice and concise, approval from my side.
Thanks, this is welcome. I originally wrote the benchmarks so I can review this relatively easily. I'm now on vacation, but will try to get to it Monday. |
Oh thats great ! I wasn't sure who made the benchmarks but I knew you weren't free, which is why I didn't tag you. Enjoy your vacation ! |
Sorry, something came up with another library I maintain and which is currently used in teaching. I have at least figured out the problem there, so I hope to have some time over the weekend to give feedback (I have a few points based on a first quick look). |
What is it ?
For people experimenting on mesa features, and needing to use the benchmarks without waiting for the PR to do it automatically. Took me a bit of time to understand what exactly benchmarking was and how to run it so I made a readme to help.
I think benchmarking is a very useful feature that could be put forward a bit more (even in mesa.readthedocs.io)